search

timduly4 / pyglow

Upper atmosphere climatological models in Python
MIT License
104 stars 57 forks source link

make only uses default python #100

Closed aburrell closed 5 years ago

aburrell commented 5 years ago

The make file for the models isn't set up so that you can run each of the commands separately. This is a problem when your computer's default python command isn't the one you want to use for this installation. This could be addressed by breaking out the different make commands into separate bits and using all for the combo, instead of having source be a combo as well, and adding documentation so that the user knows they may need to run the download command themselves. Alternatively, this could be addressed by allowing the user to specify the python version through the command line: 

make -C src/pyglow/models source PYTHON=/opt/anaconda3/bin/python
aburrell commented 5 years ago

This is also an issue for the f2py commands.

timduly4 commented 5 years ago

I don't like having the user run multiple make commands. I prefer running make -C src/pyglow/models source PYTHON=/opt/anaconda3/bin/python

This is also an issue for the f2py commands.

Where does this occur?

aburrell commented 5 years ago

The f2py commands occur for all of the fortran models. It should probably be defined in the top level make and sent down, same as the python command: make -C src/pyglow/models source PYTHON=/opt/anaconda3/bin/python F2PY=/opt/local/bin/f2py

timduly4 commented 5 years ago

@aburrell Can you make a PR for this?

aburrell commented 5 years ago

Sure, but I won't get to it for a while.

aburrell commented 5 years ago

Made changes, but can't figure out how to push the branch here. Working on a remote system, so not my normal set up.

timduly4 commented 5 years ago

Here's instructions for making a PR: https://help.github.com/en/articles/creating-a-pull-request

aburrell commented 5 years ago

Yeah, I had looked those and several other help guides up and couldn't get it to work. Found a few links to known git bugs before I ran out of time to track down what the real problem was. I'll have another go in a while, but probably not for the next 2 weeks.

From: Timothy Duly notifications@github.com Reply-To: timduly4/pyglow reply@reply.github.com Date: Sunday, April 21, 2019 at 10:34 To: timduly4/pyglow pyglow@noreply.github.com Cc: "Burrell, Angeline" angeline.burrell@nrl.navy.mil, Mention mention@noreply.github.com Subject: Re: [timduly4/pyglow] make only uses default python (#100)

Here's instructions for making a PR: https://help.github.com/en/articles/creating-a-pull-request

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/timduly4/pyglow/issues/100#issuecomment-485256492, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABVYF7UR5FJJ5JRFTQTS5VLPRR3NFANCNFSM4G7IRBQA.

timduly4 commented 5 years ago

I'll close for now, feel free to reopen when you can submit a PR.