time-rs / time

The most used Rust library for date and time handling.
https://time-rs.github.io
Apache License 2.0
1.13k stars 281 forks source link

Make the date_time method on struct DateTimeOffset public #705

Closed PolpOnline closed 2 months ago

PolpOnline commented 2 months ago

I don't know what were the motivations behind it being private (if any)

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.6%. Comparing base (4a74924) to head (a9db86c). Report is 43 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #705 +/- ## ======================================= - Coverage 97.8% 97.6% -0.2% ======================================= Files 81 83 +2 Lines 9378 9008 -370 ======================================= - Hits 9169 8790 -379 - Misses 209 218 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jhpratt commented 2 months ago

I recommend you search before opening a pull request; this has been denied repeatedly.

369

390

395

454

458

553

658

673