search

timgott / wayfire-shadows

Wayfire plugin that adds window shadows
MIT License
22 stars 3 forks source link

master branch fails to build with wayfire-git #7

Closed akliuxingyuan closed 2 years ago

akliuxingyuan commented 2 years ago

http://ix.io/4g8B

timgott commented 2 years ago

Judging from the error messages it might fixed the same way as in other plugins https://github.com/WayfireWM/wayfire-plugins-extra/pull/141/files

Can you try replacing framebuffer_t by render_target_t and see if it compiles?

EDIT: I tried myself, it fixes the compilation, will update when I have tested it

NamorNiradnug commented 2 years ago

It complies now, but shadow is offset from the window. screenshot_2022-11-18-111831

There is no offset while moving or resizing the window.

timgott commented 2 years ago

Is the offset constant or does it depend on the window position? e.g., if you move the window to the top left corner, is the offset of the shadow relative to the window still the same?

NamorNiradnug commented 2 years ago

Is the offset constant or does it depend on the window position? e.g., if you move the window to the top left corner, is the offset of the shadow relative to the window still the same?

It depends on position Closer to left top the offset is less

timgott commented 2 years ago

That's what you get if you try to find the right offsets by trial and error :sweat_smile:

Should be fixed now.