Add missing buffs and debuffs

[timhul]

Background

The current set of buffs and debuffs are not complete as there are dozens and dozens of more or less usable buffs and debuffs. The goal in this issue is not to completely implement every single possible buff and debuff, but implement some important and fairly common ones (at least for hardcore raiding).

Missing Buffs

• Battle Squawk (added in ff40498ebfc6732ad4fbb17df45c7f4858738e04)
• Silithid buff
• Warchief's Blessing
• list not complete yet

Missing Debuffs

• Curse of Recklessness
• Thunderfury (x2) (for debuff limit purposes)
• Judgement of Wisdom
• Curse of Elements
• Curse of Shadows
• Gift of Arthas
• Winter's Chill
• Improved Scorch
• Shadow Weaving
• Demo Shout (for debuff limit purposes)

Debuff limit on target

It is important that the debuffs are implemented such that they afflict a marker debuff on the target whenever it is up. This is to accurately take up slots on the debuff table, pushing weaker priorities off the table.

Future SharedDebuff implementations

Note that for now these buffs should only be available as ExternalBuffs. In the future some shall also be available as SharedDebuffs. These are:

• CoR/CoE/CoS (when warlocks are implemented)
• Winter's Chill / Improved Scorch (when mages are implemented)
• Shadow Weaving (when priests are implemented)
• Demo Shout (maybe implemented for warriors in the future)

Definition of Done

The listed buffs and debuffs have been implemented.

[timhul]

A few buffs and enchants were added in ff40498ebfc6732ad4fbb17df45c7f4858738e04.

[Jinnai]

Blessed Sunfruit is also missing

Edit: and Dense Weightstone

[timhul]

Blessed Sunfruit is also missing

Edit: and Dense Weightstone

Added in ca0362c06e7ad642f8a3311548c6386757a94487 and 196ee4062a17a61aa549eb98dfc49b51d602206e.

[Jinnai]

Thank you, however Dense Weightstone still can't be applied to Fist Weapons.

[timhul]

Thank you, however Dense Weightstone still can't be applied to Fist Weapons.

Good catch, fixed in 9ef72267ea21ec555ae967cc8ad6f1e81c785313.

[steffen678]

What about Druid buffs? Would be useful to have Leader of the Pack and Moonkin Aura as an option.

[timhul]

What about Druid buffs? Would be useful to have Leader of the Pack and Moonkin Aura as an option.

I intially held off on adding those since the goal with party buffs was/is to add them via selecting group members in Raid Setup. Battle Shout (and probably other that I'm not considering at the moment) was added as a regular buff before the Raid Setup pane was added, but they would then also be converted into buffs provided by party members. The intent would be to avoid impossible buff setups.

Another aspect with providing party buffs or raid debuffs via Raid Setup is a more realistic uptime of certain buffs. Nightfall for example would be applied by adding a party member that has Nightfall equipped and fully simulating that character's rotation. The concept is mostly supported today with the exception that there are no template characters that has Nightfall equipped (and there currently being a crash when selecting members outside of your party). Further, changing template characters requires recompilation as they are hardcoded. I'd like to make it possible to change any aspect of each template character via the GUI, or at least via file.

A bit long-winded, but essentially I haven't added them as buffs because it means making "double the work" since the intended solution is of a greater scope.

[ssateneth]

bumping for wanting leader of the pack buff too.

[timhul]

WCB added in 56814118639b4da5c058612bb9f3558598dc84ff.

[Robnroll]

Hey, just noticed that some mage buffs / foods are missing. The smaller version of SP potion "Arcane Elixir". "Elixir of Frost Power" and Runn Tum Tuber Surprise. Nothing really important just would be nice to check the impact of using them ;)

[Zwoxlol]

Elixir of Shadow Power is missing

https://classic.wowhead.com/item=9264/elixir-of-shadow-power