timmbogner / Farm-Data-Relay-System

A system that uses ESP-NOW, LoRa, and other protocols to transport sensor data in remote areas without relying on WiFi.
MIT License
485 stars 108 forks source link

Clean up of #72 #74

Closed Gulpman closed 1 year ago

Gulpman commented 1 year ago

I needed to define a USE_ESPNOW in fdrs_gateway_config.h to make things easier. Actually this is needed anyway as it is not obligatory for a gateway to offer ESP-Now support. As the gateway code does not offer a central starting point like beginFDRS() as the sensor does, I had to implement the config check in the .ino file. This has been done only in 4_UART_Gateway so far.

timmbogner commented 1 year ago

beginFDRS() for the gateway would be a fine addition. Making ESP-NOW optional is a good idea in theory, but would be a big undertaking for not much payoff. That's the main reason I haven't done it. You're welcome to change it if it makes your life easier 😉

Gulpman commented 1 year ago

Making ESP-NOW optional is a good idea in theory, but would be a big undertaking for not much payoff. That's the main reason I haven't done it. You're welcome to change it if it makes your life easier 😉

Done 😊 See https://github.com/timmbogner/Farm-Data-Relay-System/pull/74/commits/ae85886e65ccaf403ded30b7c670b9a9a979ef80