search

timomeh / react-native-material-bottom-navigation

💅🔧👌 a beautiful, customizable and easy-to-use material design bottom navigation for react-native
MIT License
709 stars 127 forks source link

Readme - Bottom Navigation props incorrect name #17

Closed prashantham closed 7 years ago

prashantham commented 7 years ago

activelabelColor - should have been activeLabelColor

timomeh commented 7 years ago

You're absolutely right! Do you want to open a PR or should I fix it in the README?

prashantham commented 7 years ago

Have not done any PR. I will give it a try.

On Tue, 21 Mar 2017, 14:04 Timo Mämecke, notifications@github.com wrote:

You're absolutely right! Do you want to open a PR or should I fix it in the README?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/timomeh/react-native-material-bottom-navigation/issues/17#issuecomment-288009434, or mute the thread https://github.com/notifications/unsubscribe-auth/ABwKxOlTpBL8wAfEH6u7W69272Etp4Wvks5rn4ulgaJpZM4MjWyO .

timomeh commented 7 years ago

Docs are always a good way to get into PRs. Try it, don't panic, I won't bite.

timomeh commented 7 years ago

Closed with #18.