Some spring cleaning

[bHimes]

Remove footguns from numeric text file, expand tests and remove duplicated defines and replace with constepxr.

Description

• Already working on something that requires NumericTextFile, so I decided to clean up a few cases where error handling was incomplete or not present.
• Renamed and refactored a few variables for clarity
• Enabled default construction without initialization
• Removed duplicated code (replaced with template)
• Add doxygen comments to primary functions
• Remove duplicate defines for OPEN_TO_WRITE/READ/APPEND and moved to constexpr so the compiler knows and can check types.

NOTE: the behavior of the constructor/OPEN argument "wanted_records_per_line" is a bit misleading as it seems to only be valid when OPEN_TO_WRITE

NOTE: OPEN_TO_APPEND is not implemented - added a debug assert

For expand symmetry stack and par, just removed nested comments to clear a compiler warning and also to reduce clutter when doing repo wide regex.

Fixes # (issue)

I have rebased my feature branch to be current with the master branch using to minimize conflicts and headaches

• [D] yes
• [ ] no

Which compilers were tested

• [ ] g++
• [D] icpc
• [ ] clang
• [ ] other (please specify)

These changes are isolated to the

• [ ] gui
• [D] core library
• [ ] gpu core library
• [ ] program it modifies

How has the functionality been tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

• [ ] Tested manually from GUI
• [ ] Tested manually from CLI
• [X] Passed console tests
• [ ] Passed samples functional testing
• [ ] other (please specify)

Checklist:

• [ ] I have not changed anything that did not need to be changed
• [X] I have performed a self-review of my own code
• [X] I have commented my code, (w.r.t. why), particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation {Ok to pass for now}
• [X] My changes generate no new warnings
• [X] Any dependent changes have been merged and published in downstream modules