search

timroes / EnhancedListView

[DEPRECATED] An Android ListView with enhanced functionality (e.g. Swipe To Dismiss or Undo)
Other
463 stars 147 forks source link

added rearranging #18

Closed schrockblock closed 10 years ago

timroes commented 10 years ago

Hi, is there a special reason, why you closed the pull request? Was going to look into it within the next days.

schrockblock commented 10 years ago

Hey, yes, I had meant to pull request it with my fork's master branch, not with your code base. Besides, it's not a swipe-to-dismiss related commit, it's not as thoroughly commented/documented, and only perfunctorily tested. If you're interested, it incorporates an example from Google's DevBytes series that manages drag-and-drop rearranging. If you want to incorporate it (which would be an increase in scope) I'd be happy to make it a little more robust, document it, and resubmit, but I'd be surprised if you did. Thanks, and excellent work!

timroes commented 10 years ago

Hi, its fine the way it is :-) I will anyway comment it completely and change some stuff (e.g. add drag handle as alternative to long press, etc.). But I can use this is a base. And since my plan is to add also other features (not only swipe to dismiss) to the list it's fine. So I hope I will find some time, and then use this as a code base.