timthedevguy / BGHUDAppKit

* BGHUDAPPKIT is no longer under development by me, I hope that the community will keep it alive and going as I no longer have time to dedicate to the project** The missing HUD controls. Please scroll down to read the readme file for an important notice concerning the future of BGHUDAppKit. Note that there are multiple versions available, 10.5+, 10.6.7, and now 10.7. As soon as I learn how I'll make these all one code base if possible.
http://www.binarymethod.com/
312 stars 57 forks source link

BGHUDTableView should use BGHUDTextFieldCells? #12

Closed rjo closed 13 years ago

rjo commented 14 years ago

I have noticed that when editing a table cell the cursor color is black, making it pretty hard to see what one is editing. Looking at the code, it seems that BGHUDTableView is using a default NSTextFieldCell rather than a BGHUDTextFieldCell, which would makethe cursor the same as the text color. I've tried to implement this but when I set the table column cell to an instance of BGHUDTextFieldCell the fields become non-editable and I can't figure out why.

An example of my attempt to use the custom cell type is at http://pastebin.com/m23107dda

Anyone know whats up with that?

rjo commented 14 years ago

I'm a dork ... didn't consider setting the cell type in IB which works just fine.

timthedevguy commented 14 years ago

Just got off work, sorry for the long delay. I didn't make it those the default cells because it wasn't really needed. I just overrode the default handling of text based cells within BGHUDTableView so that it would display those cells colors based on the tableview's own themeKey. I know I shouldn't assume that users would want this the same, but I'm a horrible person lol :)

But true, I will see if I can persuade the cursor to become the color we want in my default implementation :)

rjo commented 14 years ago

One thing I did notice in that if one happens to have a hud text field in a view, and edits it, that changes the insertion point color rather permanently such that all other text fields then get the new cursor color. If that is ok, you could just get a reference to the shared field editor in the table view and change it there. I still cant figure out why my method above didn't fly though

timthedevguy commented 14 years ago

Somehow I missed this last post, I'll look at that, I may need to cache the original color and set it back.

timthedevguy commented 14 years ago

Ok, so I figured a temporary solution, in this commit c025a450d189d7733a83, this is far from permanent as it is still kinda quirky, but will have to do until I can figure out how to use custom field editor.

timthedevguy commented 13 years ago

fixed

rjo commented 13 years ago

Awesome ... thanks for stickin with it BG!

timthedevguy commented 13 years ago

oops, this was supposed to be left open. Sorry for the confusion, this is now I Known Issue