search

timthedevguy / BGHUDAppKit

* BGHUDAPPKIT is no longer under development by me, I hope that the community will keep it alive and going as I no longer have time to dedicate to the project** The missing HUD controls. Please scroll down to read the readme file for an important notice concerning the future of BGHUDAppKit. Note that there are multiple versions available, 10.5+, 10.6.7, and now 10.7. As soon as I learn how I'll make these all one code base if possible.
http://www.binarymethod.com/
312 stars 57 forks source link

NSImage in BGHUDPopUpButtonCell #2

Closed mahal closed 14 years ago

mahal commented 14 years ago

Have you planned to draw the image of a Cell inside a BGHUDPopUpButtonCell?

timthedevguy commented 14 years ago

Good point, I'll get on it.

timthedevguy commented 14 years ago

Issue #2 - BGHUDPopupButtonCell Image

This update fixes issue #2, BGHUDPopUpButtonCell image drawing. Currently only Left/Right/NoImage settings are supported. Closed by b0f09f2a6b9e645e346a415b2f9154c0c91c2e79

alinebee commented 14 years ago

There's a bug in this implementation, whereby popup menu items will draw their images upside-down. This is because BGHUDPopUpButtonCell's -drawImage:withFrame:inView: is flipping the image to draw it (correctly) into the popup button, but leaving it flipped afterwards, so the menu item draws the flipped version.

This can be fixed by adding [image setFlipped: NO]; at the button of drawImage::withFrame:inView: after all drawing has been done. Of course, if more modifications would be made to the image in future versions, then a copy of the image should be made and modified instead.

timthedevguy commented 14 years ago

Ah, good catch!!!!

timthedevguy commented 14 years ago

Fixes BGHUDPopUpButtonCell image fliped'ness

Fixed the image fliped'ness. Thanks to alunbestor for catching this. Closed by 8a1d9bd0672e9c80c4764e03c8442e662e5bc5f1