search

timthedevguy / BGHUDAppKit

* BGHUDAPPKIT is no longer under development by me, I hope that the community will keep it alive and going as I no longer have time to dedicate to the project** The missing HUD controls. Please scroll down to read the readme file for an important notice concerning the future of BGHUDAppKit. Note that there are multiple versions available, 10.5+, 10.6.7, and now 10.7. As soon as I learn how I'll make these all one code base if possible.
http://www.binarymethod.com/
312 stars 57 forks source link

memory leak fix #40

Closed niltsh closed 13 years ago

niltsh commented 13 years ago

I am not the fix is proper, but I saw the "path" is released elsewhere.

timthedevguy commented 13 years ago

Good catch, I'll pull it in now!

niltsh commented 13 years ago

Hi, sorry for bothering.

I thought you must be busy with the appstore issue.

I just download src in the master, and use the static analysis in Xcode simply. Actually there are 10 warnings from Xcode, and I just fix only 2 of them, since I really do not how to use git. I edited the src in the browser...

So actually, the pull request is a just remind. : )

I have my own personal project, which is a media player called MPlayerX. http://code.google.com/p/mplayerx/

MPlayerX uses your framework heavily. So if there are something I could contribute, I feel honored.

And still, there are 8 left...

timthedevguy commented 13 years ago

niltsh,

No problem, I'll run the Static Analyser and see what pops up, thanks for the information :) And your MPlayerX looks pretty awesome so far, like what you did with the color/hue shader.

timthedevguy commented 13 years ago

nitsh,

This may be a stupid question but how did you set up your static analyse? I tried and I don't get any errors so I must be doing something wrong.

EDIT: I figured it out, lol, I'll get the errors fixed

niltsh commented 13 years ago

the basic settings of the project I have changed are

  1. Architectures -> Standard (32/64-bit Universal)
  2. Base SDK -> Mac OS X 10.5
  3. C/C++ Compiler Version -> LLVM compiler 1.5

I thought LLVM was the key.