search

timthedevguy / BGHUDAppKit

* BGHUDAPPKIT is no longer under development by me, I hope that the community will keep it alive and going as I no longer have time to dedicate to the project** The missing HUD controls. Please scroll down to read the readme file for an important notice concerning the future of BGHUDAppKit. Note that there are multiple versions available, 10.5+, 10.6.7, and now 10.7. As soon as I learn how I'll make these all one code base if possible.
http://www.binarymethod.com/
312 stars 57 forks source link

Vertical slider doesn't draw correctly in disabled state (patch included) #56

Open garethsb-ghost opened 13 years ago

garethsb-ghost commented 13 years ago

BGHUDAppKit looks great. Thank you, Tim!

BGHUDSliderCell doesn't draw a vertical slider correctly in the disabled state. I think this is just an oversight and easily fixed by applying the code from the horizontal variant:

diff /Users/garethsb/Development/binarygod-BGHUDAppKit-79a560d/Framework/BGHUDSliderCell.m /Users/garethsb/Development/binarygod-BGHUDAppKit-79a560d-patched/Framework/BGHUDSliderCell.m 
308,312c308,322
<    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] sliderTrackColor] set];
<    [path fill];
<    
<    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];
<    [path stroke];

---
>    if([self isEnabled]) {
>        
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] sliderTrackColor] set];
>        [path fill];
>        
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];
>        [path stroke];
>    } else {
>        
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledSliderTrackColor] set];
>        [path fill];
>        
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
>        [path stroke];
>    }

Thanks, Gareth Sylvester-Bradley

timthedevguy commented 13 years ago

hmmm...I don't remember ever getting a notice of this one, I'll definitely get this and your other fixes in the repo, thanks for the help and sorry for the late reply.