search

timthedevguy / BGHUDAppKit

* BGHUDAPPKIT is no longer under development by me, I hope that the community will keep it alive and going as I no longer have time to dedicate to the project** The missing HUD controls. Please scroll down to read the readme file for an important notice concerning the future of BGHUDAppKit. Note that there are multiple versions available, 10.5+, 10.6.7, and now 10.7. As soon as I learn how I'll make these all one code base if possible.
http://www.binarymethod.com/
312 stars 57 forks source link

Should button outlines be drawn in the disabledStrokeColor in the disabled state? (patch included) #57

Open garethsb-ghost opened 13 years ago

garethsb-ghost commented 13 years ago

Should button outlines be drawn in the disabledStrokeColor in the disabled state? In particular, the disabled state of an unchecked HUD checkbox is hard to distinguish from an enabled one.

I've patched BGHUDButtonCell.m locally as follows:

diff /Users/garethsb/Development/binarygod-BGHUDAppKit-79a560d/Framework/BGHUDButtonCell.m /Users/garethsb/Development/binarygod-BGHUDAppKit-79a560d-patched/Framework/BGHUDButtonCell.m >diff.txt
403c403
<        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
510c510
<        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
591c591
<        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
891c891
<        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
916c916
<                [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>                [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
961c961
<                    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>                    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
983c983
<                    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>                    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];

Best regards, Gareth