search

tinderjs / tinder-desktop

Use Tinder from your desktop, for Mac OS X, Microsoft Windows and Linux
https://tinderjsblog.herokuapp.com/
97 stars 25 forks source link

Move to npm #167

Closed gdborton closed 7 years ago

gdborton commented 7 years ago

Copy/pasta from commit messages...

Pull font-awesome from CDN rather than installing. Using font-awesome as a dependency was creating additional build overhead. Since we're already loading the Raleway font from Google's CDN, I didn't see a reason not to load this font from a CDN as well.

This cuts down on the build logic, and also makes the migration to npm and away from bower easier. Lastly it will cut down on diff churn as the fonts and css were checked into the repository.

Move away from bower.json and to using npm. This completely removes bower from the install and build process, preferring npm. npm is becoming the defacto package manager, and works very well with commonjs. Electron also works with commonjs, so this helps to reduce build logic as well.

After this is merged, I think that https://github.com/tinderjs/tinder-desktop/issues/72 can be closed.

gdborton commented 7 years ago

@mrmayfield ping.

stuwil commented 7 years ago

Nicely done @gdborton, thanks!