search

tinkerbell / lint-install

Consistently install reasonable linter rules for open-source projects
Apache License 2.0
6 stars 7 forks source link

multi-module repos: find: ‘out/linters/golangci-lint-v1.43.0-x86_64’: No such file or directory #39

Closed tstromberg closed 2 years ago

tstromberg commented 2 years ago

If you run make golangci-lint-lint in a repository that has multiple go.mod packages, it fails:

mv out/linters/golangci-lint out/linters/golangci-lint-v1.43.0-x86_64
find . -name go.mod -execdir "out/linters/golangci-lint-v1.43.0-x86_64" run -c "" \;
find: ‘out/linters/golangci-lint-v1.43.0-x86_64’: No such file or directory
find: ‘out/linters/golangci-lint-v1.43.0-x86_64’: No such file or directory
find: ‘out/linters/golangci-lint-v1.43.0-x86_64’: No such file or directory
find: ‘out/linters/golangci-lint-v1.43.0-x86_64’: No such file or directory
find: ‘out/linters/golangci-lint-v1.43.0-x86_64’: No such file or directory
find: ‘out/linters/golangci-lint-v1.43.0-x86_64’: No such file or directory

I believe what is happening here is that execdir is relative to the current working directory, which keeps changing from module to module.