search

tinted-theming / base24

Base24/ Base16 can be used to easily generate your favourite theme for your favourite application. Many of the template repositories provide theme files that you can copy/ import into said application.
MIT License
68 stars 7 forks source link

Adjust styling table formatting and bright/non-bright terminal colours #28

Closed JamyGolden closed 2 months ago

JamyGolden commented 2 months ago

I've created a PR https://github.com/tinted-theming/home/pull/110 which makes the bright/non-bright situation a bit more explicit for Base16.

Since Base24 is a superset of base16, we should theoretically be able to use a base24 colour palette for base16 and it would generate the same thing. The way things are now Base24's base08 - base0E is considered "not bright", however the colours used here tend to be less saturated than base10 - base17 - so in practise Base24's "bright" terminal colours are typically less bright.

People also tend make themes with highly saturated colours, so adding a "bright" variant becomes more difficult than adding a less saturated variant. Of course this isn't always the case, there can be themes that have low saturation, and in those cases a bright variant would be easy to add and a less saturated variant would be more difficult to add, so things won't always work out perfectly.

With this in mind, what are your thoughts with this edit? Do you agree with the above, etc?

FredHappyface commented 2 months ago

Yeah I think I'm happy with this. Makes a lot of sense given the use of saturated colours for base 16.

This is a backwards incompatible change imo with the old base24. That is the base24 schemes/ theme templates will need swapping around to accommodate this. Particularly for terminal themes.

I've not a problem with that, just something we need to keep in mind. I'm wondering how best we can communicate this. To me, it's a major version change and possibly a notice on the repo highlighting this

JamyGolden commented 2 months ago

Hmm, I guess it comes down to whether we want bright colours to be used for “Variables, XML Tags, Markup Link Text, Markup Lists, Diff Deleted” etc or if those should be less saturated. Maybe it makes sense to have those as less saturated and we just change the colours for the base24 variant and be ok that the base24 scheme would look different if used for building a base16 template than building the base16 template using the corresponding base16 scheme.

belak commented 2 months ago

In regards to the backwards-incompatible changes - if we're using the automated builders, as long as we merge template changes and scheme updates before the automated builders run, we can at least make it work for all our "official" templates.

FredHappyface commented 2 months ago

Yeah I'm absolutely happy with that then.

JamyGolden commented 2 months ago

What do you two think about bright colours being base08-base0E vs the “non bright” colours? I’m asking because I don’t actually have a strong opinion on it, just as long as it’s hinted at which one is the default in the spec so we can carry that across to base24. So I can merge the PR, but I just want to hear what you think about that decision in particular, even if your feeling is “doesn’t matter to me”.

JamyGolden commented 2 months ago

Closing this PR since I forgot about this PR and ended up creating another PR: https://github.com/tinted-theming/base24/pull/30 😅