tinted-theming / base24

Base24/ Base16 can be used to easily generate your favourite theme for your favourite application. Many of the template repositories provide theme files that you can copy/ import into said application.
MIT License
68 stars 7 forks source link

Specify bright colours first to match base16 specification #30

Closed JamyGolden closed 2 months ago

JamyGolden commented 2 months ago

I decided against merging this last week since I didn't feel like we had a strong reason to change the base24 spec, but I think a strong reason to change it is that it is most intuitive to keep base00-base0F the same in both the base16 scheme and base24 scheme when creating a base24 scheme.

What is a "Bright" colour?

A bright colour is perceived "bright" typically when the luminance and the saturation are higher values compared to another colour.

Examples of current spec not being intuitive

CleanShot 2024-09-08 at 00 09 43@2x

The proposed PR change would actually make most of the base24 schemes fall in line with the spec

FredHappyface commented 2 months ago

My understanding with the colour palettes given are that bases 12-17 are 'lighter' than bases 8 to A, which appear more saturated. To clarify, is the understanding that these are the 'bright' colours? If so I actually think it might be worth clarifying this, that the most saturated colours are bases 8 to A

Thoughts?

JamyGolden commented 2 months ago

Yeah sounds good, I've added a line to define "Bright" - I'm happy to change anything about it.

FredHappyface commented 2 months ago

Yeah sounds good, I've added a line to define "Bright" - I'm happy to change anything about it.

In those examples the brighter colurs have higher saturation but not higher luminance

In many cases I had decided what I thought were bright colours by increading the luminance by 10 percentage points (certainly not suggesting that was right, but more background on what I did at the time)

That said, I'm happy for bright to mean both lighter (more luminance) and more saturated

JamyGolden commented 2 months ago

Yeah I get that. It’s complicated with colours and something can seem “brighter” with a certain colour even if it’s technically not. A milky colour might not seem brighter compared to a more saturated colour, but a milk red is brighter than a dark red. It all depends on the colours in that palette and isn’t really something we can strictly define.

I think we could say “Bright” refers to intensity, vividness or luminance of the colour. At the end of the day it doesn’t really matter too much as long as the two colours are different variants of the same colour.

JamyGolden commented 2 months ago

We could also add an image for clarity (even though it's not a hard rule): Screenshot from 2024-09-11 10-12-58