[Bug report] Git delta hook unknown option and light value issues

JamyGolden commented 1 year ago

Describe the bug

@bezhermoso I've noticed 2 issues with the new git delta hook:

The -g option doesn't exist for me
The is_light_theme variable has either the values 0 or 01 which causes the light value to give an error: (eval):9: command not found: 01

These screenshots are with the removal of the -g option for bc command on line 19.

Works correctly when setting a dark theme

Does not work correctly when setting a light theme (notice # is_light_theme = 01 on line 18)

Operating system: Pop!Os (Linux)

Terminal: Alacritty

JamyGolden commented 1 year ago

I've created a PR to fix this, @bezhermoso maybe you can do a quick review? https://github.com/tinted-theming/base16-shell/pull/33

JamyGolden commented 1 year ago

This issue has been fixed. Look at the merged PR for more details https://github.com/tinted-theming/base16-shell/pull/33