search

tintoy / dotnet-kube-client

A Kubernetes API client for .NET Standard / .NET Core
MIT License
192 stars 33 forks source link

Upgrade to a newer version of YamlDotNet #144

Open tomsseisums opened 3 years ago

tomsseisums commented 3 years ago

The project depends on YamlDotNet 6.1.2, where the latest is 11.2.1. https://github.com/tintoy/dotnet-kube-client/blob/11381a787c34b59ceaf1ef8e63425c023257792b/src/KubeClient/KubeClient.csproj#L17

We hadn't explicitly added YamlDotNet to our project and relied on the internal dependency provided by KubeClient, we ended up having a threading problem related to deserialization which got resolved by explicitly upgrading to a later version.

I came to realization to upgrade by checking YamlDotNet's code and I found out that the v6 implementation in some places are not async/threading friendly, our case was one of them.

The project works otherwise, so I'd imagine it's a safe upgrade.

tintoy commented 3 years ago

Thanks! I’ll give this a try and if the tests still pass I’ll put out a new release sometime today 😅