search

tiny-pilot / ansible-role-ustreamer

Ansible role for µStreamer streaming service
MIT License
9 stars 13 forks source link

Make EDID conform with edid-decode checks #108

Closed db39 closed 1 year ago

db39 commented 1 year ago

Our previous EDIDs failed to conform with edid-decode's --check flag. This updated EDID has a number of modifications to make it conform with the tests - fixing the warnings and failed attributes.

Warnings fixed:

IT Video formats are now underscanned by default.

There are no longer multiple native progressive timings defined.

Failures fixed:

Detailed Timing Descriptor 1 no longer lists an image size. Detailed Timing Descriptor 2 no longer lists an image size.

Display Range Limits now sets the correct bytes: Byte 11 is 0x00 and Bytes 12-17 are now 0x20.

There are no longer more Native Detailed Timing Descriptors than Detailed Timing Descriptors.

Removed duplicate video data definition (VIC 60)

Adjusted monitor ranges to 24-90 Hz (Vertical Freq) and 18-80 kHz (Horizontal Freq) Review on CodeApprove

db39 commented 1 year ago

@mtlynch - I've tested this EDID and found no issues so far.

I added --check to the decode test and it seems to work as expected.

Is there anything else that to do before a review?

mtlynch commented 1 year ago

You mentioned having to work around AW EDID Editor bugs. Can we document those in the comment above the EDID?

db39 commented 1 year ago
Automated comment from CodeApprove ➜

⏳ @mtlynch please review this Pull Request