search

tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.
https://tinypilotkvm.com
MIT License
2.99k stars 250 forks source link

Replace isort with ruff #1632

Closed mtlynch closed 11 months ago

mtlynch commented 11 months ago

Replace isort with ruff. ruff is way faster and does the same checks. It gives us about a 35x performance improvement over isort:

isort

$ time isort \
  --recursive \
  --force-single-line-imports \
  --top log \
  --diff \
  --check-only \
  --skip-glob=third_party/* \
  --skip-glob=venv/*

Skipped 2073 files

real    0m1.975s
user    0m1.743s
sys     0m0.229s

ruff

$ time ruff check \
  app/ \
  scripts/render-template \
  scripts/update-service

real    0m0.063s
user    0m0.014s
sys     0m0.073s

Review on CodeApprove

mtlynch commented 11 months ago
Automated comment from CodeApprove ➜

⏳ @jotaen4tinypilot please review this Pull Request