search

tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.
https://tinypilotkvm.com
MIT License
2.99k stars 250 forks source link

Cache Python virtualenv in CircleCI #1634

Closed mtlynch closed 11 months ago

mtlynch commented 11 months ago

Review on CodeApprove

mtlynch commented 11 months ago

@jdeanwallace, @jotaen4tinypilot - Do you have an opinion on whether this is worth doing?

Last few build_python builds on master (excluding "Spin up environment stage"):

Builds of build_python step on this branch with caching:

So, we're saving 5-18s, but we're also adding CI complexity. And this isn't a CI step that gates other steps, and it's far from the slowest CI step, so it feels like not really worth the extra complexity to me, but I wanted to see if anyone was in favor of it.

jotaen4tinypilot commented 11 months ago

I don’t have a super strong opinion, though I’m generally slightly sceptical of caching on CI, due to the complexity, and because it may be a source of subtle, hard-to-reproduce issues.

Seeing the rather marginal gains here, I’d also lean towards not doing it.

jdeanwallace commented 11 months ago

I vote for no-go. We have slower fish to fry.

mtlynch commented 11 months ago

Cool, glad we're on the same page!