search

tinygo-org / bluetooth

Cross-platform Bluetooth API for Go and TinyGo. Supports Linux, macOS, Windows, and bare metal using Nordic SoftDevice or HCI
https://tinygo.org
Other
744 stars 137 forks source link

RSSI naming #272

Closed elgohr closed 5 months ago

elgohr commented 5 months ago

Is the description of https://github.com/tinygo-org/bluetooth/blob/12b6f0bc25b665a683fd3143cfaef76dadfb619b/gap.go#L109 correctly? In other contexts RSSI stands for Received Signal Strength Indicator, which would be the strength of the signal received. When I see it correctly this is also what is implemented - isn't it?

aykevl commented 5 months ago

The comment is perhaps a bit confusing. Every incoming advertisement packet can have a different RSSI value (due to noise, change in distance, people moving around, etc) so this value the RSSI value from the last received packet. Perhaps a better comment would be:

// The RSSI value of the received advertisement packet.
elgohr commented 5 months ago

I would go for Signal strength of the advertisement packet..

Otherwise we explain RSSI with RSSI...