tinygo-org / drivers

TinyGo drivers for sensors, displays, wireless adaptors, and other devices that use I2C, SPI, GPIO, ADC, and UART interfaces.
https://tinygo.org
BSD 3-Clause "New" or "Revised" License
622 stars 196 forks source link

go.mod weirdness or my stupidity? #699

Open gherlein opened 3 months ago

gherlein commented 3 months ago

If I have a go.mod with:

module tinygo.org/x/drivers

I get this error:

gherlein@io:~/src/tinygo/m$ go mod tidy
go: finding module for package tinygo.org/x/drivers/mcp2515
go: tinygo.org/x/drivers imports
    tinygo.org/x/drivers/mcp2515: cannot find module providing package tinygo.org/x/drivers/mcp2515: unrecognized import path "tinygo.org/x/drivers/mcp2515": reading https://tinygo.org/x/drivers/mcp2515?go-get=1: 404 Not Found

If I change the go.mod to

module tinygo.org/drivers

it works.

I'm too new to go.mod foo to really grok this but it does not seem right.

aykevl commented 3 months ago

It looks like the redirect is missing here: https://github.com/tinygo-org/tinygo-site/tree/dev/static/x/drivers

A workaround is indeed to use the module tinygo.org/x/drivers, but to avoid this issue in the future a small file needs to be added to tinygo-site to add the right redirect.

deadprogram commented 3 months ago

See https://github.com/tinygo-org/tinygo-site/pull/419 for PR that adds the missing files.

gherlein commented 3 months ago

so fast! Great. How do I learn more about the module index stuff? It seems that tinygo.org/x/drivers/mcp2515 is somehow pointing to https://tinygo.org/x/drivers/mcp2515?go-get=1 - which you fixed the redirect. But how do I get smarter on where the index lives that does that mapping? If you know I'd love a pointer so I get smarter.

thanks again for the very fast fix.

deadprogram commented 3 months ago

See https://pkg.go.dev/cmd/go#hdr-Remote_import_paths for more info

gherlein commented 3 months ago

Thanks!

gherlein commented 3 months ago

See tinygo-org/tinygo-site#419 for PR that adds the missing files.

If I get a wild hair and want to propose some documentation updates, are you guys open to PRs for the web site?

deadprogram commented 3 months ago

Absolutely yes!