search

tinygo-org / drivers

TinyGo drivers for sensors, displays, wireless adaptors, and other devices that use I2C, SPI, GPIO, ADC, and UART interfaces.
https://tinygo.org
BSD 3-Clause "New" or "Revised" License
622 stars 196 forks source link

Onewire improvements #706

Closed HattoriHanzo031 closed 1 month ago

HattoriHanzo031 commented 1 month ago

Some improvements to OneWire/DS18B20 driver.

Although external pull-up resistor for DS18B20 is recommended, internal pull-up is good enough in some cases (for example for single sensor on a short bus), so low level functions are changed to enable internal pull-up for high state.

While testing DS18B20 sensor without internal or external pull-up, I got panic because OneWire Search function "found" more than 32 devices and overflowed the array. To prevent this, the check is added to stop the search (and return an error) when more than 32 devices are found. Also, CRC check was added to prevent adding invalid devices during search.

Additionally PR contains suggestion for changing Crc8 method and in turn OneWireDevice interface (which is a breaking change) to be a bit more idiomatic Go. This is only a suggestion and I would like to get other opinions on it.

deadprogram commented 1 month ago

Thank you very much for the improvements @HattoriHanzo031 now merging.