search

tipsy / j2html

Java to HTML generator. Enjoy typesafe HTML generation.
https://j2html.com/
Apache License 2.0
765 stars 136 forks source link

support osgi meta data in provided jar. #112

Closed Naxos84 closed 6 years ago

Naxos84 commented 6 years ago

I like to use this lib in an osgi environment. Therefore I added the necessary plugins during build to provide OSGI meta data in MANIFEST.MF

tipsy commented 6 years ago

Hmm.. I don't really know antyhing about osgi, but I'm guessing you've built this locally and tested it?

Naxos84 commented 6 years ago

Of course I tested it locally. Just for reference: https://www.ibm.com/support/knowledgecenter/en/SSEQTP_8.5.5/com.ibm.websphere.osgi.doc/ae/ra_bundle_mf.html

If you check the created MANIFEST.MF in target/classes/META-INF then you see that the unnecessary things are generated.

David notifications@github.com schrieb am Di., 17. Apr. 2018, 16:47:

Hmm.. I don't really know antyhing about osgi, but I'm guessing you've built this locally and tested it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tipsy/j2html/pull/112#issuecomment-382020088, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ_OIVkXW8JSOk9kjVy9xXlvqI7eaexTks5tpgCRgaJpZM4TYde4 .

tipsy commented 6 years ago

@Naxos84 could this affect backwards compatibility in any way?

Naxos84 commented 6 years ago

It should not. Cause every info that was present in old MANIFEST is still available. But to be honest I'm not sure for 100% (Just for 99% or so)...

David notifications@github.com schrieb am Di., 17. Apr. 2018, 21:55:

@Naxos84 https://github.com/Naxos84 could this affect backwards compatibility in any way?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tipsy/j2html/pull/112#issuecomment-382121320, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ_OIYXQVxVMI6CygZJ-jX0uHjcasqaiks5tpki-gaJpZM4TYde4 .

tipsy commented 6 years ago

Alright. From what I read it seems it should be fine.

tipsy commented 6 years ago

Thanks!

Naxos84 commented 6 years ago

Btw. If you don't want to export every package from this project, please let me know and we may be able to fix that too.

tipsy commented 6 years ago

This has been released in 1.3.0 now.

tipsy commented 6 years ago

Btw. If you don't want to export every package from this project, please let me know and we may be able to fix that too.

Are you talking about jigsaw modules or osgi?