🐞 反馈问题：OpenAI Translate Error While OpenAI Translate is disabled

tisfeng / Raycast-Easydict

A Raycast Extension for looking up words or translating text in an easy way. Support 48+ languages, support Linguee and Youdao dictionary, support OpenAI, DeepL, Google, Bing, Apple, Baidu, Tencent, Volcano, Youdao and Caiyun translation.

https://www.raycast.com/isfeng/easydict

MIT License

382 stars 21 forks source link

🐞 反馈问题：OpenAI Translate Error While OpenAI Translate is disabled #36

Closed zhenpewu closed 1 year ago

zhenpewu commented 1 year ago

请先确认以下事项

[X] 已仔细阅读了 README
[X] 在 issues 页面搜索过问题，但未能找到解决方法
[X] Easydict 已升级到最新版本

问题描述

The error notification pop up while OpenAI Translate is disabled, the error message the API token is not provided.

Screen Shot 2023-03-28 at 13 56 01

重现步骤

N/A

期望结果

If any service is disabled, the related error message should not pop up.

解决方案（可选）

No response

github-actions[bot] commented 1 year ago

Hello zhenpewu, Thank you for your first issue contribution 🎉

zhenpewu commented 1 year ago

I believe it is due to this line https://github.com/tisfeng/Raycast-Easydict/blob/74665f7b384fe0f547eb91f05bcec44e2a873216/src/dataManager/dataManager.ts#L745

tisfeng commented 1 year ago

Thank you for your feedback. You are right. Initially, I commented out the code when testing it and forgot to uncomment it later.

zhenpewu commented 1 year ago

I have raised one PR https://github.com/tisfeng/Raycast-Easydict/pull/37, feel free to merge it.