search

tjikko-studio / components

Component library for Tjikko Studio apps
0 stars 0 forks source link

Header and Footer seem broken on Storybook #149

Closed shawninder closed 2 years ago

shawninder commented 3 years ago

Header is missing logo. Footer colors are wrong, probably a mix-up between dark and light modes…

shawninder commented 2 years ago

From https://smpx.tjikko-studio.a2hosted.com/en/home:

Screen Shot 2021-10-02 at 14 07 56

Notice the wrong colors. Alignment is also wrong, but should be fixed by next release.

ktryndchrs commented 2 years ago

@shawninder && @philipdokic This issue is caused by missing spaces in the footer wrapper classes

I think I will leave to anyone of you the task to solve this as the problem only seems to be on prod.

Note: The class sp_ace-y-12 is not needed here (and also useless). I thi k I am the one responsible of this class being there

image

shawninder commented 2 years ago

I can no longer reproduce this bug locally. I'll merge the next batch of PRs, deploy everything, and then we can check again whether this issue still occurs or not.

As for sp_ace-y-12, I can remove that classname. Or should I replace it with space-y-12? Let me know @ktryndchrs

ktryndchrs commented 2 years ago

The said class is not needed, thanks!

shawninder commented 2 years ago

This is still a problem on the frontend in prod, although I can no longer reproduce it locally, nor anywhere in Storybook…

miherb commented 2 years ago

Do we have some ideas how to fix this? Could we remove the light mode as a temporary workaround?