search

tjikko-studio / components

Component library for Tjikko Studio apps
0 stars 0 forks source link

Remove the empty nav "folders" in the sitenav #154

Closed shawninder closed 2 years ago

shawninder commented 2 years ago

The current solution of a tiny empty space doesn't seem ideal; see screenshots below:

From https://smpx-storybook.tjikko-studio.a2hosted.com/?path=/story/tjikko-nav-elements-navitem--none:

Screen Shot 2021-10-01 at 15 44 16

From https://smpx.tjikko-studio.a2hosted.com/en/home:

Screen Shot 2021-10-01 at 15 44 47

@ktryndchrs @PierreDG @miherb

miherb commented 2 years ago

It should not be a folder, but rather open directly a portfolio page.

miherb commented 2 years ago

This is still a problem on production. The portfolio is just a button that leads to another page. It's not a folder.

Screen Shot 2021-10-06 at 11 11 40 PM
miherb commented 2 years ago

I could also put it as a new issue somewhere more relevant. Let me know @shawninder @ktryndchrs

shawninder commented 2 years ago

I could also put it as a new issue somewhere more relevant. Let me know @shawninder @ktryndchrs

No this is the place, we just have to get around to it

ktryndchrs commented 2 years ago

I will fix it this afternoon and also add the burger nav (On two separate branches)