search

tjikko-studio / components

Component library for Tjikko Studio apps
0 stars 0 forks source link

Svg logo and icons fix #164

Closed ktryndchrs closed 2 years ago

ktryndchrs commented 2 years ago

💁‍♀️ Description

For some reason, adding any properties to an SVG imported using react-svg-loader removes the viewBox property. This is what caused the search box to be broken… For the moment, the best fix is to simply add it.

The best solution would be to use react-inlinesvg everywhere, but it has issue with webpack export. So far everything seems to work great on both backend and storybook! I suggest to leave it as is for the moment.

👉 To consider

Changes won't be apparent right now on the backend branch as we need to update the fields on this branch!

⚠️ Note

Regarding the the relation to Remove any client-specific data and logic #55, this request only partially solve it as there are probably other SMPX related content that will be updated on other specific updates

shawninder commented 2 years ago

For some reasons, adding any properties to imported svg using react-svg-loader remove the property viewBox.

Let's find that reason, what do you think?

shawninder commented 2 years ago

Will this fix our viewBox problem @ktryndchrs ? https://github.com/tjikko-studio/components/pull/170

ktryndchrs commented 2 years ago

@shawninder I think you had a fix for the that has been merged. I guess these two comments are no longer a problem:

For some reasons, adding any properties to imported svg using react-svg-loader remove the property viewBox.

Let's find that reason, what do you think?

Will this fix our viewBox problem @ktryndchrs ? #170