search

tjikko-studio / components

Component library for Tjikko Studio apps
0 stars 0 forks source link

Tell SVGO not to remove the viewBox attribute #170

Closed shawninder closed 2 years ago

shawninder commented 2 years ago

@ktryndchrs What do you think?

ktryndchrs commented 2 years ago

It seems to work (yay)

Following this, a few updates will be needed here: https://github.com/tjikko-studio/components/pull/164

shawninder commented 2 years ago

Have these updates been made yet?

ktryndchrs commented 2 years ago

It was merged no? 🤔

shawninder commented 2 years ago

This PR was merged, yes, but not #164 , which needs to be updated now that this is fixed. Indeed, we probably no longer need to manually set a viewBox everywhere since it's no longer being removed by SVGO…