search

tjikko-studio / components

Component library for Tjikko Studio apps
0 stars 0 forks source link

Header and footer logo #175

Closed ktryndchrs closed 2 years ago

ktryndchrs commented 2 years ago

@shawninder While making my corrections, I made this change ant it worked. Thanks for the tip! https://github.com/tjikko-studio/components/pull/175#discussion_r724401302

ktryndchrs commented 2 years ago

Regarding these two comments @shawninder https://github.com/tjikko-studio/components/pull/175#discussion_r724403760 https://github.com/tjikko-studio/components/pull/175#discussion_r724405624

Media contain specific helpers such as shadow and figcaptions, etc. All we need here is to insert image as is.

PS: (wtf is wrong with Github… I can't answer to these comment directly >_>, is it me or it is not possible?)

shawninder commented 2 years ago

PS: (wtf is wrong with Github… I can't answer to these comment directly >_>, is it me or it is not possible?)

Strange… I can add replies directly to those comments, and you also can do it usually, no? I wonder what changed…

shawninder commented 2 years ago

Media contain specific helpers such as shadow and figcaptions, etc. All we need here is to insert image as is.

I think these should be optional when using the Media component, making it THE component for all our media…

ktryndchrs commented 2 years ago

Media contain specific helpers such as shadow and figcaptions, etc. All we need here is to insert image as is.

I think these should be optional when using the Media component, making it THE component for all our media…

You're the boss!

ktryndchrs commented 2 years ago

@shawninder I must admit that the advantage of using the tag is that the code is leaner! 👍