search

tjikko-studio / components

Component library for Tjikko Studio apps
0 stars 0 forks source link

Design Collection component #205

Closed starjdave closed 2 years ago

starjdave commented 2 years ago

https://github.com/tjikko-studio/SMPX-Website/issues/58

ktryndchrs commented 2 years ago

@philipdokic Great! Now the Portfolio list just need to like displayed on the original issue 👍 https://github.com/tjikko-studio/SMPX-Website/issues/59

shawninder commented 2 years ago

Here you can see that when I add the Collection block to a page, it disappears from the preview when I save that page, reappearing only once I refresh the page:

https://user-images.githubusercontent.com/484730/139097397-f5d36d65-88ec-4c3c-9996-5a79abfbf79b.mov

shawninder commented 2 years ago

The other thing missing here is the auto-generated SideNav. You can see this in the Figma designs and there is already a component for it called SideNav (not to be confused with SiteNav) which you can see working in Storybook. Of course, if the existing component needs tweaking that's fine.

Figma designs:

SideNav component in Storybook:

starjdave commented 2 years ago

Here you can see that when I add the Collection block to a page, it disappears from the preview when I save that page, reappearing only once I refresh the page:

preview-bug-success-stories.mov

Fix here: https://github.com/tjikko-studio/SMPX-Backend/pull/103