tjikko-studio / components

Component library for Tjikko Studio apps
0 stars 0 forks source link

Stories rely on running backend #209

Closed shawninder closed 2 years ago

shawninder commented 2 years ago

Example: https://github.com/tjikko-studio/components/blob/b459a80a7810f892e6cd2a8c8a1bcd8250c8fa5e/src/blocks/Gallery.stories.tsx#L33

This image will only be available if the backend is running and has that image in the content. This isn't my case so I just get broken images.

Storybook should stand on its own, it shouldn't need to rely on the backend or the content. We can use images included in the components repo or any other image accessible via a permanent URL.

There are a few occurrences of this throughout the code, which you can search for here: https://github.com/tjikko-studio/components/search?q=127.0.0.1%3A8000

This issue will be resolve when that search yields 0 results.

shawninder commented 2 years ago

This is what I see at the moment, for example, when I look at the Gallery in Storybook locally:

Screen Shot 2021-10-27 at 19 12 45
ktryndchrs commented 2 years ago

I will solve this sorry 🤦‍♀️

shawninder commented 2 years ago

Removed storybook so this is no longer an issue