search

tjikko-studio / components

Component library for Tjikko Studio apps
0 stars 0 forks source link

flex gap issue on Brave #240

Closed shawninder closed 2 years ago

shawninder commented 2 years ago

See below (all on mac):

Firefox Screen Shot 2021-11-25 at 19 28 01

Safari Screen Shot 2021-11-25 at 19 27 54

Chrome Screen Shot 2021-11-25 at 19 28 14

Opera Screen Shot 2021-11-25 at 19 27 38

Brave Screen Shot 2021-11-25 at 19 28 23

On Brave, notice how much is broken by not having a vertical or horizontal flex gap! The nav bar, the hero contents, the primary block!

ktryndchrs commented 2 years ago

Thanks…

shawninder commented 2 years ago

Any idea what's causing this?

ktryndchrs commented 2 years ago

Ok… that one is……… Streannngeeee……… Because me, It works except the navbar that is fucked up!

https://user-images.githubusercontent.com/416462/143521968-a5650799-9f5a-48a2-834d-766b098bb145.mp4

ktryndchrs commented 2 years ago

What is your exact version of Brave?

I will look a little deeper at it as I really don't like this

shawninder commented 2 years ago

Hmm, I just updated Brave and I no longer see the problem… I don't use Brave very much so I may have been a few months behind on my updates last time I tried, but not years so I can't be the only one out there with the issue…

ktryndchrs commented 2 years ago

I think it was related to flex gap which is a new feature (finally) https://caniuse.com/flexbox-gap

I guess we may close this issue then

shawninder commented 2 years ago

This looks like the issue we're still having on iOS, so I'll just add a reference as we close it: https://github.com/tjikko-studio/components/issues/268