tjikko-studio / components

Component library for Tjikko Studio apps
0 stars 0 forks source link

Missing translations for hard-coded texts #273

Closed shawninder closed 2 years ago

shawninder commented 2 years ago

Heads up @miherb

There are places (e.g. the Calendly component) in our code with hard-coded text (e.g. the field labels in the case of the Calendly component). We'll need to find a way to hard-code a french version of those texts and show the appropriate text based on the currently selected language…

Known problematic texts:

What Where English Suggested French translation Confirmed
Field label Calendly form Company Compagnie No
Field label Calendly form Name* Nom No
Field label Calendly form Email* Courriel No
Field label Calendly form Phone Téléphone No
Textarea label Calendly form Tell us more about your needs and we’ll prepare accordingly Faites-nous part de vos besoins et nous nous préparerons en conséquence No
Button label Calendly form Next Suivant No
shawninder commented 2 years ago

I fixed this (will be pushing this with the next release) but we'll need to confirm what the desired translations are (aka if my translations are correct).

Also, in the future, it would be a better idea to make all those labels customizable, avoid the "translation-of-hard-coded-texts" problem entirely by avoiding hard-coded texts themselves.