search

tjturnage / pyart-nexrad

Pyart sandbox
0 stars 1 forks source link

EDT is hard coded for the image label timestamp #10

Open ericlenning opened 4 years ago

ericlenning commented 4 years ago

May wish to move this into config file or determine it from user's local environment.

ericlenning commented 4 years ago

A related issue would be the time_shift which also is hard coded as an offset from UTC.

tjturnage commented 4 years ago

Wonder if we can add this to the config template? Python should offer a way to determine DST ... https://docs.python.org/3/library/time.html#timezone-constants Maybe a project for Victoria?

ericlenning commented 4 years ago

Some challenges here: maybe the user wants to generate images with labels for a different timezone than their own. Maybe their machine is UTC but they want a USA timezone. Maybe their machine is a local timezone but they want UTC labels. The eventual goal is to have a GUI send most of the config information to the script. The local config is like a GUI placeholder. So yes, we should add this to the config template and not determine it on the fly.