search

tjturnage / pyart-nexrad

Pyart sandbox
0 stars 1 forks source link

New class to list and download AWS files. #16

Closed ericlenning closed 4 years ago

ericlenning commented 4 years ago

resolves #5 resolves #14 resolves #15

Takes listing and downloading functionality out of pyart_plot.py and moves it to a special class for this purpose called NexradLevel2.

Allows for downloading of files across more than one day (i.e. across 00z).

Fixes bug where filename on AWS was assumed to be a certain length.

Checks first to see if desired filename is already downloaded and of the same size as the file on AWS. If so, does not re-download.

tjturnage commented 4 years ago

Thanks for integrating this! I'd like to see this get built out eventually to include satellite requests.

ericlenning commented 4 years ago

As I thought about this, and what to name the module and the class, it occurred to me that the download method could be used for any AWS file list. It's the filelist method that needs to know about the unique naming conventions of different datatypes. So I started with a NexradLevel2 class, the only class presently in the module. But imagine a NexradLevel3 class, or a GOESSatellite class, or anything else. And if the download method is in fact identical for all of them, maybe they could all inherit from a superclass containing that method.