search

tkahn / Smooth-Div-Scroll

A jQuery plugin for smooth scrolling. No longer maintained.
471 stars 184 forks source link

is event.stopPropagation() necessary? #163

Closed mjvotaw closed 3 months ago

mjvotaw commented 10 years ago

I'm using your plugin as part of a dropdown menu, to display a series of items that the user can horizontally scroll through. The mouseleave event on line 435 prevents the dropdown from closing, because it stops the event from bubbling up to its container.

While this is easy enough to work around (I just have a second mouseleave event on the element I smothDivScoll'ed), I have to wonder if stopping the event propagation is necessary? If I comment out the offending line, there doesn't appear to be any immediate problems, but I'm by no means using all of the functionality available in this plugin.

tkahn commented 10 years ago

No, I don't think this is necessary. You could comment them out in a copy and report back if it generates any negative side effects. If not, I can remove them. :-)

mjvotaw commented 10 years ago

As far as I can tell, there haven't been any negative side effects. I commented them out last week when I posted about this, and as far as I can tell, everything seems to be working as expected.