search

tkf / emacs-request

Request.el -- Easy HTTP request for Emacs Lisp
http://tkf.github.com/emacs-request/
GNU General Public License v3.0
629 stars 93 forks source link

Don't use tramp-make-tramp-file-name function #106

Closed juergenhoetzel closed 5 years ago

juergenhoetzel commented 5 years ago

Emacs 26 added two new required arguments to tramp-make-tramp-file-name. Additionally, the method part of remote file names is mandatory.

Also ensure request--make-temp-file creates temporary files in the temporary folder on the remote host (instead of default-directory).

titaniumbones commented 5 years ago

@juergenhoetzel could you please rebase and change the target of this PR to development? I'm trying to avoid committing directly to master anymore (have only recently realized that I was publishing new packages to MELPA every time master changed!)

Also: this doesn't seem to break Emacs 25 builds, but I thought I might as well ask why it doesn't. (EDIT: actually read the ocmmit message so now I undertand). And if the tests already cover this case (I don't htink they do) & how hard it would be to add test coverage.

juergenhoetzel commented 5 years ago

@juergenhoetzel could you please rebase and change the target of this PR to development?

I just rebased and changed the target branch to development

titaniumbones commented 5 years ago

Sorry this took me so long to merge, I went away to a conference and thought I had already done this!