search

tkloht / react-video-cover

A small React component rendering a <video/> with object-fit: cover, or a Fallback if object-fit is not available.
http://tkloht.github.io/react-video-cover
MIT License
58 stars 14 forks source link

componentWillReceiveProps has been renamed #210

Open davidrhoderick opened 4 years ago

davidrhoderick commented 4 years ago

When trying to use the forceFallback property, I get the following error:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: VideoCoverFallback
davidrhoderick commented 4 years ago

Also, I was going to add this is a minor issue but it appears to break the passing of attributes to the rendered <video> tag.