tl-its-umich-edu / remote-office-hours-queue

Virtual queuing tool supporting Zoom video conferencing and/or in person meetings.
https://officehours.it.umich.edu/
Apache License 2.0
12 stars 28 forks source link

#197 Handle meetings with no attendees, add delete action #498

Closed jaydonkrooss closed 5 months ago

jaydonkrooss commented 5 months ago

197 Addresses the issue we've been seeing with meetings without attendees. My solution is to just handle the issue client-side, allowing users to view all affected meetings and manually remove them.

Test plan to replicate local development environment:

  1. On a manage meeting page, add a user to the meeting queue (for in-person meeting)
  2. Click "ready for attendee" to admit the user to the "Meetings in Progress" section
  3. In local DB, delete the attendee from the officehours_api_attendee table (where meeting_id is from the id from officehours_api_meeting table): delete from officehours_api_attendee where meeting_id={meeting_id}
  4. On browser, open the console and refresh the page. You should see a meeting with the message "Invalid meeting ID:" and no attendee. It should have a trash icon to delete the meeting
  5. Delete the meeting by pressing the delete button and confirming. Double check the database to see that the meeting info is fully cleared

To test the meeting without attendees in just the Meeting Queue, repeat the above but skip over step 2

jxiao21 commented 5 months ago

Works as you described. Just making sure I understand, the goal is that if there is a meeting with no attendees, that it will say somewhere that the meeting is invalid and that it needs to be deleted? I think it may help to make it a little more clear to the user with something a little more eye-catching that the meeting should be deleted if that's the case.

jaydonkrooss commented 5 months ago

Works as you described. Just making sure I understand, the goal is that if there is a meeting with no attendees, that it will say somewhere that the meeting is invalid and that it needs to be deleted?

Yes, the invalid data should be presented as opposed to crashing the page, which we saw before.

I think it may help to make it a little more clear to the user with something a little more eye-catching that the meeting should be deleted if that's the case.

Good suggestion, I'll look into some error message or at least changing the text inside the table to be more clear.

jaydonkrooss commented 5 months ago

@jxiao21 I just added a suggestion to delete the meeting in the table entries. This is a rare scenario to begin with so I think that will suffice to indicate to the user that the invalid meeting should be removed.