tl-its-umich-edu / remote-office-hours-queue

Virtual queuing tool supporting Zoom video conferencing and/or in person meetings.
https://officehours.it.umich.edu/
Apache License 2.0
12 stars 28 forks source link

Fixes #497: User Preferences bugs, refactor form logic for phone settings #500

Closed jaydonkrooss closed 5 months ago

jaydonkrooss commented 5 months ago

Pretty significant rework of the user preferences to address tricky bugs. Uses a new child component and more descriptive state for organizing form logic. Now should be properly responsive to different types of changes, including phone verification, clearing settings, and notification checkboxes.

See comments in #497 for test cases that properly address changes.

jxiao21 commented 5 months ago

Did this branch work off of the updated version of the master branch? I'm running into Twilio issues again when I check into this branch.

jaydonkrooss commented 5 months ago

@jxiao21 Forgot to pull in the changes, you can try it out now

jxiao21 commented 5 months ago

Ah I see you just went through and removed the unused code while I was reviewing it haha