search

tl-its-umich-edu / remote-office-hours-queue

Virtual queuing tool supporting Zoom video conferencing and/or in person meetings.
https://officehours.it.umich.edu/
Apache License 2.0
12 stars 28 forks source link

BadHeaderError if EMAIL_SUBJECT_PREFIX has newlines #559

Open jonespm opened 1 month ago

jonespm commented 1 month ago

If EMAIL_SUBJECT_PREFIX contains newlines in the config there's an error like this one which makes debugging impossible.

django.core.mail.message.BadHeaderError: Header values can't contain newlines (got '[TEST_ROHQ] \nERROR (EXTERNAL IP): Internal Server Error:

While we can change this config, the code should ensure that this is value has newlines removed.

jonespm commented 4 weeks ago

Adding this to 1.12.0, it's a simple fix but it's also fixed by having a correct configuration file which we have control over.

jadfalaoui commented 21 hours ago

Hello, I would love to work on this issue in the context of my final assignment for EECS 481: Software Engineering. Please let me know if this error is still occurring in the latest build!

jonespm commented 20 hours ago

Hi @jadfalaoui, yes this is still an issue and probably an easy fix similar to #473.

That issue even added a test case but it didn't check for this case.