search

tlaplus / vscode-tlaplus

TLA+ language support for Visual Studio Code
MIT License
357 stars 33 forks source link

Add TLC Debugger #214

Closed lemmy closed 3 years ago

lemmy commented 3 years ago

The TLC Debugger has matured to the point where users find it useful: https://twitter.com/vanlightly/status/1395672906466746368

Demo: https://youtu.be/6oMQYHogQek

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

alygin commented 3 years ago

@lemmy, thanks for all the effort you put into the debugger! @klinvill, thanks for reviewing!

alygin commented 3 years ago

Published in v1.6.0-alpha.1.

lemmy commented 3 years ago

We/I screwed up when merging the new prompt by @klinvill. Launching the debugger no longer opens the prompt but runs with whatever command-line parameters are found in some settings scope. This is wrong.

klinvill commented 3 years ago

@lemmy, I believe the fix just requires setting the showOptionsPrompt argument here to be true: https://github.com/alygin/vscode-tlaplus/blob/dcb3cd4cc98fb5f7f7d41db374c6fbf7482f4d24/src/debugger/debugging.ts#L86

alygin commented 3 years ago

Fixed, thanks

lemmy commented 3 years ago

What about releasing the nightly build of the extension to the VSCode market (under a separate extension id)?