search

tlaplus / vscode-tlaplus

TLA+ language support for Visual Studio Code
MIT License
357 stars 33 forks source link

Syntax highlighting active outside of module boundaries #217

Closed lemmy closed 3 years ago

lemmy commented 3 years ago 
Text up here shouldn't cause "shouldn" to be highlighted (the syntax grammar thinks "shouldn" is a primed variable).
----- MODULE M -----
...
=====

syntax

alygin commented 3 years ago

This is very similar to #117. Semantic highlighting is stable since VSCode v1.48, so it should be doable.

ahelwer commented 3 years ago

@lemmy the toolbox highlights keywords and comments outside of module boundaries; is this desired behavior?

lemmy commented 3 years ago

I don't know if this is intentional, but I like its behavior better than highlighting don't, doesn't, .... Perhaps, the pretty-printer is the authority?

edaena commented 3 years ago

Proposed fix https://github.com/alygin/vscode-tlaplus/pull/243

lemmy commented 3 years ago

Marking as closed thanks to @edaena!