search

tlaplus / vscode-tlaplus

TLA+ language support for Visual Studio Code
MIT License
357 stars 33 forks source link

Try loading a spec/cfg with the MC prefix before loading the #233

Closed lemmy closed 3 years ago

lemmy commented 3 years ago

file matching the current editor

Essentially, this introduce the convention that TLC-related modules and config files are prefixed with 'MC'.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

lemmy commented 3 years ago

I have been using the feature for a while now and find it useful.

lemmy commented 3 years ago

Thanks for the review. I'm happy to revise the PR if we all agree that this MC convention (potentially extended to MC as prefix and suffix) is a good idea. Alternatively, the extension could open a file chooser instead of offering to create a config file if it can't find a .cfg file for the current editor.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

lemmy commented 3 years ago

@alygin Please review even though this has been merged. I"m confident, but a second pair of eyes never hurts. The reason why I've already merged is to test-drive the functionality at an internal workshop this week.