search

tlaplus / vscode-tlaplus

TLA+ language support for Visual Studio Code
MIT License
357 stars 33 forks source link

The `tlaplus.tlaps.check-step` key-binding breaks VSCode's "go to line number" binding #308

Closed eddyashton closed 1 year ago

eddyashton commented 1 year ago

This change adds a tlaplus.tlaps.check-step command, with default binding ctrl+g ctrl+g. This conflicts with the existing (VSCode default) binding, where Ctrl + G runs the "Go to Line/Column" command.

The default binding should be changed, to avoid conflicting with any default bindings for system commands.

It looks like none of the existing commands from this extension install key bindings by default, so perhaps this binding should just be removed (and interested users can configure their own, locally).

lemmy commented 1 year ago

@eddyashton Is this Windows? Ctrl + G doesn't seem to be a system command on macOS.

eddyashton commented 1 year ago

@eddyashton Is this Windows? Ctrl + G doesn't seem to be a system command on macOS.

@lemmy Yes this was on Windows. The VSCode docs suggest that this is also Ctrl+G on MacOS.

Windows:

image

MacOS:

image

Though that's weirdly inconsistent with similar bindings so perhaps it's actually Cmd+G?

Regardless, it won't work if this keybinding is present in the extension, and will instead show a "first part of chord pressed" message in the status bar.