python3.10: numpy update and explicit int()

tlecomte / friture

Real-time audio visualizations (spectrum, spectrogram, etc.)

http://friture.org

GNU General Public License v3.0

936 stars 161 forks source link

python3.10: numpy update and explicit int() #207

Closed imyxh closed 2 years ago

imyxh commented 2 years ago

In Python 3.10, the Numpy C extensions refuse to build; this is fixed by setting the dependency to numpy>=1.21.1.
Implicit conversions to int are deprecated and enforced, as of Python 2.10. I think I have removed all implicit conversions from float to int, but I might've missed some, or done something in the wrong way. Review would be appreciated.

Fixes #204. Fixes #206.

imyxh commented 2 years ago

Okay, sounds good! I just pushed a new commit to my fork but for some reason it hasn't shown up here.... If it takes much longer I can just make a new PR.

imyxh commented 2 years ago

Uhhhh okay I'm closing this one and submitting a new PR, someone else had the same issue and filed a bug here: https://github.com/github/feedback/discussions/10767