search

tleonardi / nanocompore

RNA modifications detection from Nanopore dRNA-Seq data
https://nanocompore.rna.rocks
GNU General Public License v3.0
78 stars 12 forks source link

Unexposed log_dwell options #58

Closed tleonardi closed 5 years ago

tleonardi commented 5 years ago

The log_dwell option of gmm_test() is not used anywhere and should be removed.

a-slide commented 5 years ago

Remove in branch doc https://github.com/tleonardi/nanocompore/commit/853606cb4ebb14ee28b92c7542bbbfdf526b59d3

tleonardi commented 5 years ago

Now it looks like we are not doing the log of the dwell time at all... did you remove global_dwell = np.log10(global_dwell) accidentally or am I missing something?

a-slide commented 5 years ago

That was an error. Sorry

a-slide commented 5 years ago

This one can be closed right ?

tleonardi commented 5 years ago

Yep!